From fc6fc579227ea4f37fdca7feb8b6e864ca14f18a Mon Sep 17 00:00:00 2001
From: James Ketrenos <james_git@ketrenos.com>
Date: Sat, 7 Jun 2025 09:38:53 -0700
Subject: [PATCH] Scrolling in sub pages is working correctly

---
 frontend/src/components/JobManagement.tsx     |  25 +-
 frontend/src/components/JobMatchAnalysis.tsx  |   4 +-
 .../src/components/layout/BackstoryLayout.tsx |  12 +-
 frontend/src/pages/FindCandidatePage.tsx      |  73 +-----
 frontend/src/pages/JobAnalysisPage.tsx        | 227 ++++++------------
 5 files changed, 104 insertions(+), 237 deletions(-)

diff --git a/frontend/src/components/JobManagement.tsx b/frontend/src/components/JobManagement.tsx
index 41f5055..87a7ad5 100644
--- a/frontend/src/components/JobManagement.tsx
+++ b/frontend/src/components/JobManagement.tsx
@@ -354,13 +354,20 @@ const JobManagement = (props: BackstoryElementProps) => {
     // This would call your API to extract requirements from the job description
   };
 
-    const renderJobCreation = () => {
-        if (!user) {
-          return <Box>You must be logged in</Box>;
-        }
+  const loadJob = async () => {
+    const job = await apiClient.getJob("7594e989-a926-45a2-9b07-ae553d2e0d0d");
+    setSelectedJob(job);
+  }
+  const renderJobCreation = () => {
+    if (!user) {
+      return <Box>You must be logged in</Box>;
+    }
 
       return (
-        <Box sx={{ maxWidth: 1200, mx: 'auto', p: { xs: 2, sm: 3 } }}>
+        <Box sx={{
+          mx: 'auto', p: { xs: 2, sm: 3 },
+        }}>
+          <Button onClick={loadJob} variant="contained">Load Job</Button>
           {/* Upload Section */}
           <Card elevation={3} sx={{ mb: 4 }}>
             <CardHeader
@@ -537,10 +544,10 @@ const JobManagement = (props: BackstoryElementProps) => {
     };
 
     return (
-      <Box sx={{
-        minHeight: '100vh',
-        backgroundColor: 'background.default',
-        pt: { xs: 2, sm: 3 }
+      <Box className="JobManagement"
+        sx={{
+          background: "white",
+          p: 0,
       }}>
         {selectedJob === null && renderJobCreation()}
       </Box>
diff --git a/frontend/src/components/JobMatchAnalysis.tsx b/frontend/src/components/JobMatchAnalysis.tsx
index 110ea88..3a47a36 100644
--- a/frontend/src/components/JobMatchAnalysis.tsx
+++ b/frontend/src/components/JobMatchAnalysis.tsx
@@ -322,7 +322,7 @@ const JobMatchAnalysis: React.FC<JobAnalysisProps> = (props: JobAnalysisProps) =
               </Typography>
 
               <Typography variant="h6" component="h2">
-                Backstory Job Summary:
+                Backstory Generated Job Summary:
               </Typography>
               <Typography variant="body1" component="h2">
                 {job.summary || "N/A"}
@@ -333,7 +333,7 @@ const JobMatchAnalysis: React.FC<JobAnalysisProps> = (props: JobAnalysisProps) =
 
             <Grid size={{ xs: 12, md: 6 }} sx={{ display: "flex", flexShrink: 1, flexDirection: "column" }}>
               <Typography variant="h6" component="h2">
-                Job Description:
+                Original Job Description:
               </Typography>
               <Paper sx={{ p: 2, maxHeight: "22rem" }}>
                 <Scrollable sx={{ display: "flex", maxHeight: "100%" }}>
diff --git a/frontend/src/components/layout/BackstoryLayout.tsx b/frontend/src/components/layout/BackstoryLayout.tsx
index c3873f9..a00eb26 100644
--- a/frontend/src/components/layout/BackstoryLayout.tsx
+++ b/frontend/src/components/layout/BackstoryLayout.tsx
@@ -98,26 +98,34 @@ const BackstoryPageContainer = (props : BackstoryPageContainerProps) => {
         className="BackstoryPageContainer"
         sx={{
           display: "flex",
+          flexDirection: "row", // Must be row; if column, the box will expand for all children
           flexGrow: 1,
-          p: { xs: 0, sm: 0.5 }, // Zero padding on mobile (xs), 0.5 on larger screens (sm and up)
+          p: "0 !important", // Let the first box use padding to offset main content
           m: "0 auto !important",
           maxWidth: '1024px', //{ xs: '100%', md: '700px', lg: '1024px' },
+          height: "100%", // Restrict to main-container's height
+          minHeight: 0,//"min-content", // Prevent flex overflow
           ...sx
+        }}>
+        <Box sx={{
+          display: "flex", p: { xs: 0, sm: 0.5 }, flexGrow: 1, minHeight: "min-content", // Prevent flex overflow
         }}>
             <Paper
                 elevation={2}
                 sx={{
                   display: "flex",
                   flexGrow: 1,
+                  m: 0,
                   p: 0.5,
+                  minHeight: "min-content", // Prevent flex overflow
                   backgroundColor: 'background.paper',
                   borderRadius: 0.5,
-                  minHeight: '80vh',
                   maxWidth: '100%',
                   flexDirection: "column",
                 }}>
                 {children}
             </Paper>
+        </Box>
         </Container>
     );
 }
diff --git a/frontend/src/pages/FindCandidatePage.tsx b/frontend/src/pages/FindCandidatePage.tsx
index d56b472..6971ac3 100644
--- a/frontend/src/pages/FindCandidatePage.tsx
+++ b/frontend/src/pages/FindCandidatePage.tsx
@@ -1,77 +1,10 @@
-import React, { useEffect, useState } from 'react';
-import { useNavigate } from "react-router-dom";
-import Button from '@mui/material/Button';
-import Box from '@mui/material/Box';
+import React, { } from 'react';
 
 import { BackstoryPageProps } from '../components/BackstoryTab';
-import { CandidateInfo } from 'components/CandidateInfo';
-import { Candidate, CandidateAI } from "../types/types";
-import { useAuth } from 'hooks/AuthContext';
-import { useSelectedCandidate } from 'hooks/GlobalContext';
+import { CandidatePicker } from 'components/ui/CandidatePicker';
 
 const CandidateListingPage = (props: BackstoryPageProps) => {
-    const { apiClient, user } = useAuth();
-    const { selectedCandidate, setSelectedCandidate } = useSelectedCandidate();
-    const navigate = useNavigate();
-    const { setSnack } = props;
-    const [candidates, setCandidates] = useState<Candidate[] | null>(null);
-
-    useEffect(() => {
-        if (candidates !== null) {
-            return;
-        }
-        const getCandidates = async () => {
-            try {
-                const results = await apiClient.getCandidates();
-                const candidates: Candidate[] = results.data;
-                candidates.sort((a, b) => {
-                    let result = a.lastName.localeCompare(b.lastName);
-                    if (result === 0) {
-                        result = a.firstName.localeCompare(b.firstName);
-                    }
-                    if (result === 0) {
-                        result = a.username.localeCompare(b.username);
-                    }
-                    return result;
-                });
-                setCandidates(candidates);
-            } catch (err) {
-                setSnack("" + err);
-            }
-        };
-
-        getCandidates();
-    }, [candidates, setSnack]);
-
-    return (
-        <Box sx={{display: "flex", flexDirection: "column"}}>
-            {user?.isAdmin && 
-                <Box sx={{ p: 1, textAlign: "center" }}>
-                Not seeing a candidate you like?
-                <Button
-                    variant="contained"
-                    sx={{ m: 1 }}
-                    onClick={() => { navigate('/generate-candidate') }}>
-                    Generate your own perfect AI candidate!
-                </Button>
-                </Box>
-            }
-            <Box sx={{ display: "flex", gap: 1, flexWrap: "wrap", justifyContent: "center" }}>
-                {candidates?.map((u, i) => 
-                <Box key={`${u.username}`} 
-                        onClick={() => { setSelectedCandidate(u); navigate("/chat"); }}
-                        sx={{ cursor: "pointer" }}>
-                        {selectedCandidate?.id === u.id &&
-                            <CandidateInfo sx={{ maxWidth: "320px", "cursor": "pointer", backgroundColor: "#f0f0f0", "&:hover": { border: "2px solid orange" } }} candidate={u} />
-                        }
-                        {selectedCandidate?.id !== u.id &&
-                            <CandidateInfo sx={{ maxWidth: "320px", "cursor": "pointer", border: "2px solid transparent", "&:hover": { border: "2px solid orange" } }} candidate={u} />
-                        }
-                </Box>
-                )}
-            </Box>
-        </Box>
-    );
+    return <CandidatePicker {...props} />;
 };
 
 export {
diff --git a/frontend/src/pages/JobAnalysisPage.tsx b/frontend/src/pages/JobAnalysisPage.tsx
index b5705e8..dcfdfac 100644
--- a/frontend/src/pages/JobAnalysisPage.tsx
+++ b/frontend/src/pages/JobAnalysisPage.tsx
@@ -7,25 +7,14 @@ import {
   Button, 
   Typography, 
   Paper, 
-  TextField, 
-  Grid,
-  Card,
-  CardContent,
-  CardActionArea,
   Avatar,
-  Divider,
-  CircularProgress,
-  Container,
   useTheme,
   Snackbar,
   Alert,
 } from '@mui/material';
-import SearchIcon from '@mui/icons-material/Search';
 import PersonIcon from '@mui/icons-material/Person';
 import WorkIcon from '@mui/icons-material/Work';
 import AssessmentIcon from '@mui/icons-material/Assessment';
-import DescriptionIcon from '@mui/icons-material/Description';
-import FileUploadIcon from '@mui/icons-material/FileUpload';
 import { JobMatchAnalysis } from 'components/JobMatchAnalysis';
 import { Candidate } from "types/types";
 import { useNavigate } from 'react-router-dom';
@@ -37,6 +26,7 @@ import { ComingSoon } from 'components/ui/ComingSoon';
 import { JobManagement } from 'components/JobManagement';
 import { LoginRequired } from 'components/ui/LoginRequired';
 import { Scrollable } from 'components/Scrollable';
+import { CandidatePicker } from 'components/ui/CandidatePicker';
 
 // Main component
 const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps) => {
@@ -51,44 +41,6 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
   const [activeStep, setActiveStep] = useState(0);
   const [analysisStarted, setAnalysisStarted] = useState(false);
   const [error, setError] = useState<string | null>(null);
-  const { apiClient } = useAuth();
-  const [candidates, setCandidates] = useState<Candidate[] | null>(null);
-
-  const user_type = user?.userType || 'guest';
-  const user_id = user?.id || '';
-
-  useEffect(() => {
-    if (candidates !== null || selectedCandidate) {
-      return;
-    }
-    const getCandidates = async () => {
-      try {
-        const results = await apiClient.getCandidates();
-        const candidates: Candidate[] = results.data;
-        candidates.sort((a, b) => {
-          let result = a.lastName.localeCompare(b.lastName);
-          if (result === 0) {
-            result = a.firstName.localeCompare(b.firstName);
-          }
-          if (result === 0) {
-            result = a.username.localeCompare(b.username);
-          }
-          return result;
-        });
-        setCandidates(candidates);
-      } catch (err) {
-        setSnack("" + err);
-      }
-    };
-
-    getCandidates();
-  }, [candidates, setSnack]);
-
-  useEffect(() => {
-    if (selectedCandidate && activeStep === 0) {
-      setActiveStep(1);
-    }
-  }, [selectedCandidate, activeStep]);
 
   useEffect(() => {
     if (selectedJob && activeStep === 1) {
@@ -98,13 +50,11 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
 
   // Steps in our process
   const steps = [
+    { index: 0, label: 'Select Candidate', icon: <PersonIcon /> },
     { index: 1, label: 'Job Selection', icon: <WorkIcon /> },
-    { index: 2, label: 'AI Analysis', icon: <WorkIcon /> },
+    { index: 2, label: 'Job Analysis', icon: <WorkIcon /> },
     { index: 3, label: 'Generated Resume', icon: <AssessmentIcon /> }
   ];
-  if (!selectedCandidate) {
-    steps.unshift({ index: 0, label: 'Select Candidate', icon: <PersonIcon /> })
-  }
 
   // Navigation handlers
   const handleNext = () => {
@@ -126,18 +76,38 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
   };
 
   const handleBack = () => {
+    console.log(activeStep);
+    if (activeStep === 1) {
+      setSelectedCandidate(null);
+    }
+    if (activeStep === 2) {
+      setSelectedJob(null);
+    }
     setActiveStep((prevActiveStep) => prevActiveStep - 1);
   };
 
-  const handleReset = () => {
-    // setActiveStep(0);
+  const moveToStep = (step: number) => {
+    switch (step) {
+      case 0: /* Select candidate */
+        setSelectedCandidate(null);
+        setSelectedJob(null);
+        break;
+      case 1: /* Select Job */
+        setSelectedCandidate(null);
+        setSelectedJob(null);
+        break;
+      case 2: /* Job Analysis */
+        break;
+      case 3: /* Generate Resume */
+        break;
+    }
+    setActiveStep(step);
+  }
+
+  const onCandidateSelect = (candidate: Candidate) => {
+    setSelectedCandidate(candidate);
     setActiveStep(1);
-    // setSelectedCandidate(null);
-    setSelectedJob(null);
-    // setJobTitle('');
-    // setJobLocation('');
-    setAnalysisStarted(false);
-  };
+  }
 
   // Render function for the candidate selection step
   const renderCandidateSelection = () => (
@@ -146,77 +116,7 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
         Select a Candidate
       </Typography>
       
-      {/* <Box sx={{ mb: 3, display: 'flex' }}>
-        <TextField
-          fullWidth
-          variant="outlined"
-          placeholder="Search candidates by name, title, or location"
-          value={searchQuery}
-          onChange={(e) => setSearchQuery(e.target.value)}
-          InputProps={{
-            endAdornment: (
-              <InputAdornment position="end">
-                <IconButton onClick={handleSearch} edge="end">
-                  <SearchIcon />
-                </IconButton>
-              </InputAdornment>
-            ),
-          }}
-          sx={{ mr: 2 }}
-        />
-      </Box> */}
-
-        <Grid container spacing={3}>
-        {candidates?.map((candidate) => (
-            <Grid size={{ xs: 12, sm: 6, md: 4 }} key={candidate.id}>
-              <Card 
-                elevation={selectedCandidate?.id === candidate.id ? 8 : 1}
-                sx={{ 
-                  height: '100%',
-                  borderColor: selectedCandidate?.id === candidate.id ? theme.palette.primary.main : 'transparent',
-                  borderWidth: 2,
-                  borderStyle: 'solid',
-                  transition: 'all 0.3s ease'
-                }}
-              >
-                <CardActionArea 
-                  onClick={() => setSelectedCandidate(candidate)}
-                  sx={{ height: '100%', display: 'flex', flexDirection: 'column', alignItems: 'stretch' }}
-                >
-                  <CardContent sx={{ flexGrow: 1, p: 3 }}>
-                    <Box sx={{ display: 'flex', mb: 2, alignItems: 'center' }}>
-                      <Avatar 
-                      src={candidate.profileImage}
-                      alt={candidate.firstName}
-                        sx={{ width: 64, height: 64, mr: 2 }}
-                      />
-                      <Box>
-                        <Typography variant="h6" component="div">
-                        {candidate.fullName}
-                        </Typography>
-                        <Typography variant="body2" color="text.secondary">
-                        {candidate.description}
-                        </Typography>
-                      </Box>
-                    </Box>
-                    
-                    <Divider sx={{ my: 2 }} />
-                    
-                  {candidate.location && <Typography variant="body2" sx={{ mb: 1 }}>
-                    <strong>Location:</strong> {candidate.location.country}
-                  </Typography>}
-                    <Typography variant="body2" sx={{ mb: 1 }}>
-                      <strong>Email:</strong> {candidate.email}
-                    </Typography>
-                  {candidate.phone && <Typography variant="body2">
-                    <strong>Phone:</strong> {candidate.phone} 
-                  </Typography>}
-                  </CardContent>
-                </CardActionArea>
-              </Card>
-            </Grid>
-          ))}
-      </Grid>
+      <CandidatePicker onSelect={onCandidateSelect} {...backstoryProps} />
     </Paper>
   );
 
@@ -258,30 +158,49 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
   }
 
   return (
-    <Box sx={{ maxHeight: "100%", position: "relative", display: "flex", flexDirection: "column", overflow: "hidden" }}>
+    <Box sx={{
+      display: "flex", flexDirection: "column",
+      height: "100%", /* Restrict to main-container's height */
+      width: "100%",
+      minHeight: 0,/* Prevent flex overflow */
+      maxHeight: "min-content",
+      "& > *:not(.Scrollable)": {
+        flexShrink: 0, /* Prevent shrinking */
+      },
+      position: "relative",
+    }}>
       <Paper elevation={4} sx={{ m: 0, borderRadius: 0, mb: 1, p: 0 }}>{selectedCandidate && <CandidateInfo variant="small" candidate={selectedCandidate} sx={{ width: "100%" }} />}</Paper>
-      <Scrollable sx={{ display: "flex", flexGrow: 1, maxHeight: "calc(100dvh - 234px)", position: "relative" }}>
+      <Scrollable
+        sx={{
+          position: "relative",
+          maxHeight: "100%",
+          width: "100%",
+          display: "flex", flexGrow: 1,
+          flex: 1, /* Take remaining space in some-container */
+          overflowY: "auto", /* Scroll if content overflows */
+        }}>
         <Box sx={{ display: "flex", justifyContent: "center" }}>
-        <Typography variant="subtitle1" color="text.secondary" gutterBottom>
-          Match candidates to job requirements with AI-powered analysis
-        </Typography>
+          <Typography variant="subtitle1" color="text.secondary" gutterBottom>
+            Match candidates to job requirements with AI-powered analysis
+          </Typography>
         </Box>
         <Box sx={{ mt: 4, mb: 4 }}>
           <Stepper activeStep={activeStep} alternativeLabel>
-            {steps.map(step => (
-              <Step key={step.index}>
-                <StepLabel slots={{
-                  stepIcon: () => (
-                    <Avatar
-                      sx={{
-                        bgcolor: activeStep >= step.index ? theme.palette.primary.main : theme.palette.grey[300],
-                        color: 'white'
-                      }}
-                    >
-                      {step.icon}
-                    </Avatar>
-                  )
-                }}
+            {steps.map((step, index) => (
+              <Step>
+                <StepLabel sx={{ cursor: "pointer" }} onClick={() => { moveToStep(index); }}
+                  slots={{
+                    stepIcon: () => (
+                      <Avatar key={step.index}
+                        sx={{
+                          bgcolor: activeStep >= step.index ? theme.palette.primary.main : theme.palette.grey[300],
+                          color: 'white'
+                        }}
+                      >
+                        {step.icon}
+                      </Avatar>
+                    )
+                  }}
                 >
                   {step.label}
                 </StepLabel>
@@ -294,6 +213,7 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
         {activeStep === 1 && renderJobDescription()}
         {activeStep === 2 && renderAnalysis()}
         {activeStep === 3 && renderResume()}
+      </Scrollable>
 
         <Box sx={{ display: 'flex', flexDirection: 'row', pt: 2 }}>
           <Button
@@ -307,7 +227,7 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
           <Box sx={{ flex: '1 1 auto' }} />
 
           {activeStep === steps[steps.length - 1].index ? (
-            <Button onClick={handleReset} variant="outlined">
+          <Button onClick={() => { moveToStep(0) }} variant="outlined">
               Start New Analysis
             </Button>
           ) : (
@@ -327,8 +247,7 @@ const JobAnalysisPage: React.FC<BackstoryPageProps> = (props: BackstoryPageProps
           <Alert onClose={() => setError(null)} severity="error" sx={{ width: '100%' }}>
             {error}
           </Alert>
-        </Snackbar>
-      </Scrollable>
+      </Snackbar>
     </Box>);
 };