jketreno/peddlers-of-ketran
1
0
Fork 0
Code Issues 42 Activity

Move direct DOM outside of useEffect

Browse Source 
Signed-off-by: James Ketrenos <james_eikona@ketrenos.com>
This commit is contained in:
James Ketrenos 2022-03-12 15:41:33 -08:00
parent dac755cad0
commit d7c3aa2668
1 changed files with 19 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
client/src/Board.js
View File

@ -528,11 +528,7 @@ const Board = () => {
borderOrder, borders, pipOrder, pips, tileOrder, tiles borderOrder, borders, pipOrder, pips, tileOrder, tiles
]); ]);
useEffect(() => { if (turn) {
if (!turn) {
return;
}
let nodes = document.querySelectorAll('.Active'); let nodes = document.querySelectorAll('.Active');
for (let i = 0; i < nodes.length; i++) { for (let i = 0; i < nodes.length; i++) {
nodes[i].classList.remove('Active'); nodes[i].classList.remove('Active');
@ -550,13 +546,9 @@ const Board = () => {
nodes[i].classList.add('Active'); nodes[i].classList.add('Active');
} }
} }
}, [ turn ]);
useEffect(() => {
if (!placements) {
return;
} }
if (placements) {
/* Set color and type based on placement data from the server */ /* Set color and type based on placement data from the server */
placements.corners.forEach((corner, index) => { placements.corners.forEach((corner, index) => {
const el = document.querySelector(`.Corner[data-index="${index}"]`); const el = document.querySelector(`.Corner[data-index="${index}"]`);
@ -637,9 +629,8 @@ const Board = () => {
}); });
} }
} }
}, [ placements, turn]); }
useEffect(() => {
let nodes = document.querySelectorAll(`.Pip.Robber`); let nodes = document.querySelectorAll(`.Pip.Robber`);
for (let i = 0; i < nodes.length; i++) { for (let i = 0; i < nodes.length; i++) {
nodes[i].classList.remove('Robber'); nodes[i].classList.remove('Robber');
@ -655,7 +646,6 @@ const Board = () => {
el.classList.add(robberName); el.classList.add(robberName);
} }
} }
}, [ robber, robberName ]);
const canAction = (action) => { const canAction = (action) => {
return (turn && Array.isArray(turn.actions) && turn.actions.indexOf(action) !== -1); return (turn && Array.isArray(turn.actions) && turn.actions.indexOf(action) !== -1);